[MLton-commit] r6876

[Wesley Terpstra]

The new warning detected several scoping mistakes in the library regression.


----------------------------------------------------------------------

U   mlton/trunk/regression/library/check.sml
U   mlton/trunk/regression/library/lib1.sml
U   mlton/trunk/regression/library/lib2.sml
U   mlton/trunk/regression/library/lib3.sml
U   mlton/trunk/regression/library/lib4.sml
U   mlton/trunk/regression/library/lib5.sml

----------------------------------------------------------------------

Modified: mlton/trunk/regression/library/check.sml
===================================================================
--- mlton/trunk/regression/library/check.sml	2008-09-22 09:43:21 UTC (rev 6875)
+++ mlton/trunk/regression/library/check.sml	2008-09-22 09:56:33 UTC (rev 6876)
@@ -19,10 +19,10 @@
 val getCB = _import "checkcFnPublic" public : i;
 
 (* Store our idea of what the function pointers are in symbols *)
-val () = setSI (_address "checksmlFnPrivate" : p;)
-val () = setSB (_address "checksmlFnPublic"  : p;)
-val () = setCI (_address "checkcFnPrivate"   : p;)
-val () = setCB (_address "checkcFnPublic"    : p;)
+val () = setSI (_address "checksmlFnPrivate" private : p;)
+val () = setSB (_address "checksmlFnPublic"  public  : p;)
+val () = setCI (_address "checkcFnPrivate"   private : p;)
+val () = setCB (_address "checkcFnPublic"    public  : p;)
 
 (* Have C confirm that it sees the same function pointers we do.
  * C will check the values of the variables against it's own pointers.

Modified: mlton/trunk/regression/library/lib1.sml
===================================================================
--- mlton/trunk/regression/library/lib1.sml	2008-09-22 09:43:21 UTC (rev 6875)
+++ mlton/trunk/regression/library/lib1.sml	2008-09-22 09:56:33 UTC (rev 6876)
@@ -16,10 +16,10 @@
 val getCB = _import "lib1cFnPublic" public : i;
 
 (* Store our idea of what the function pointers are in symbols *)
-val () = setSI (_address "lib1smlFnPrivate" : p;)
-val () = setSB (_address "lib1smlFnPublic"  : p;)
-val () = setCI (_address "lib1cFnPrivate"   : p;)
-val () = setCB (_address "lib1cFnPublic"    : p;)
+val () = setSI (_address "lib1smlFnPrivate" private : p;)
+val () = setSB (_address "lib1smlFnPublic"  public  : p;)
+val () = setCI (_address "lib1cFnPrivate"   private : p;)
+val () = setCB (_address "lib1cFnPublic"    public  : p;)
 
 (* Have C confirm that it sees the same function pointers we do.
  * C will check the values of the variables against it's own pointers.

Modified: mlton/trunk/regression/library/lib2.sml
===================================================================
--- mlton/trunk/regression/library/lib2.sml	2008-09-22 09:43:21 UTC (rev 6875)
+++ mlton/trunk/regression/library/lib2.sml	2008-09-22 09:56:33 UTC (rev 6876)
@@ -19,10 +19,10 @@
 val getCB = _import "lib2cFnPublic" public : i;
 
 (* Store our idea of what the function pointers are in symbols *)
-val () = setSI (_address "lib2smlFnPrivate" : p;)
-val () = setSB (_address "lib2smlFnPublic"  : p;)
-val () = setCI (_address "lib2cFnPrivate"   : p;)
-val () = setCB (_address "lib2cFnPublic"    : p;)
+val () = setSI (_address "lib2smlFnPrivate" private : p;)
+val () = setSB (_address "lib2smlFnPublic"  public  : p;)
+val () = setCI (_address "lib2cFnPrivate"   private : p;)
+val () = setCB (_address "lib2cFnPublic"    public  : p;)
 
 (* Have C confirm that it sees the same function pointers we do.
  * C will check the values of the variables against it's own pointers.

Modified: mlton/trunk/regression/library/lib3.sml
===================================================================
--- mlton/trunk/regression/library/lib3.sml	2008-09-22 09:43:21 UTC (rev 6875)
+++ mlton/trunk/regression/library/lib3.sml	2008-09-22 09:56:33 UTC (rev 6876)
@@ -19,10 +19,10 @@
 val getCB = _import "lib3cFnPublic" public : i;
 
 (* Store our idea of what the function pointers are in symbols *)
-val () = setSI (_address "lib3smlFnPrivate" : p;)
-val () = setSB (_address "lib3smlFnPublic"  : p;)
-val () = setCI (_address "lib3cFnPrivate"   : p;)
-val () = setCB (_address "lib3cFnPublic"    : p;)
+val () = setSI (_address "lib3smlFnPrivate" private : p;)
+val () = setSB (_address "lib3smlFnPublic"  public  : p;)
+val () = setCI (_address "lib3cFnPrivate"   private : p;)
+val () = setCB (_address "lib3cFnPublic"    public  : p;)
 
 (* Have C confirm that it sees the same function pointers we do.
  * C will check the values of the variables against it's own pointers.

Modified: mlton/trunk/regression/library/lib4.sml
===================================================================
--- mlton/trunk/regression/library/lib4.sml	2008-09-22 09:43:21 UTC (rev 6875)
+++ mlton/trunk/regression/library/lib4.sml	2008-09-22 09:56:33 UTC (rev 6876)
@@ -19,10 +19,10 @@
 val getCB = _import "lib4cFnPublic" public : i;
 
 (* Store our idea of what the function pointers are in symbols *)
-val () = setSI (_address "lib4smlFnPrivate" : p;)
-val () = setSB (_address "lib4smlFnPublic"  : p;)
-val () = setCI (_address "lib4cFnPrivate"   : p;)
-val () = setCB (_address "lib4cFnPublic"    : p;)
+val () = setSI (_address "lib4smlFnPrivate" private : p;)
+val () = setSB (_address "lib4smlFnPublic"  public  : p;)
+val () = setCI (_address "lib4cFnPrivate"   private : p;)
+val () = setCB (_address "lib4cFnPublic"    public  : p;)
 
 (* Have C confirm that it sees the same function pointers we do.
  * C will check the values of the variables against it's own pointers.

Modified: mlton/trunk/regression/library/lib5.sml
===================================================================
--- mlton/trunk/regression/library/lib5.sml	2008-09-22 09:43:21 UTC (rev 6875)
+++ mlton/trunk/regression/library/lib5.sml	2008-09-22 09:56:33 UTC (rev 6876)
@@ -19,10 +19,10 @@
 val getCB = _import "lib5cFnPublic" public : i;
 
 (* Store our idea of what the function pointers are in symbols *)
-val () = setSI (_address "lib5smlFnPrivate" : p;)
-val () = setSB (_address "lib5smlFnPublic"  : p;)
-val () = setCI (_address "lib5cFnPrivate"   : p;)
-val () = setCB (_address "lib5cFnPublic"    : p;)
+val () = setSI (_address "lib5smlFnPrivate" private : p;)
+val () = setSB (_address "lib5smlFnPublic"  public  : p;)
+val () = setCI (_address "lib5cFnPrivate"   private : p;)
+val () = setCB (_address "lib5cFnPublic"    public  : p;)
 
 (* Have C confirm that it sees the same function pointers we do.
  * C will check the values of the variables against it's own pointers.