[MLton-commit] r6888

Wesley Terpstra wesley at mlton.org
Tue Sep 23 19:16:47 PDT 2008


A few functions were not marked as PRIVATE.
This doesn't normally show up because -fvisibility=hidden made them private.
However, earlier gcc supported __attribute__((visibility("hidden")) but not
-fvisibility=hidden. By marking these last few symbols as PRIVATE, gcc 3.4
can still be supported.


----------------------------------------------------------------------

U   mlton/trunk/runtime/bytecode/opcode.h
U   mlton/trunk/runtime/platform.h

----------------------------------------------------------------------

Modified: mlton/trunk/runtime/bytecode/opcode.h
===================================================================
--- mlton/trunk/runtime/bytecode/opcode.h	2008-09-24 02:05:27 UTC (rev 6887)
+++ mlton/trunk/runtime/bytecode/opcode.h	2008-09-24 02:16:45 UTC (rev 6888)
@@ -193,7 +193,7 @@
 
 #define opcodeGen(z)  #z,
 
-const char *opcodeStrings [] = {
+PRIVATE const char *opcodeStrings [] = {
         opcodes ()
 };
 

Modified: mlton/trunk/runtime/platform.h
===================================================================
--- mlton/trunk/runtime/platform.h	2008-09-24 02:05:27 UTC (rev 6887)
+++ mlton/trunk/runtime/platform.h	2008-09-24 02:16:45 UTC (rev 6888)
@@ -121,7 +121,7 @@
 #endif
 
 #ifndef MLTON_CODEGEN_STATIC_INLINE
-#define MLTON_CODEGEN_STATIC_INLINE /*static inline*/
+#define MLTON_CODEGEN_STATIC_INLINE PRIVATE
 #endif
 #ifndef MLTON_CODEGEN_MATHFN
 #define MLTON_CODEGEN_MATHFN(decl) 
@@ -148,7 +148,7 @@
 /*                        Utility libraries                         */
 /* ---------------------------------------------------------------- */
 
-int mkdir2 (const char *pathname, mode_t mode);
+PRIVATE int mkdir2 (const char *pathname, mode_t mode);
 
 /* ---------------------------------------------------------------- */
 /*                        Garbage Collector                         */




More information about the MLton-commit mailing list