[MLton] Slow commits again, precommit script broken

Matthew Fluet fluet at tti-c.org
Sat Nov 3 04:47:15 PST 2007


On Sat, 3 Nov 2007, Vesa Karvonen wrote:
> I'm in a bit of a hurry right now, so I'll just report that I had to
> comment out a section from the precommit script, because it caused my
> commit to hang forever.  If you've modified the precommit script
> recently, please take a look at the script and fix the issue properly
> (make sure that it does the job without causing commits to hang).

I added the Copyright check to the precommit script.  I didn't think it 
would be any more expensive than the tab check, but I guess it is doing 
two greps, one of which is a proper regular expression (rather than a 
simple string match).  Sorry.




More information about the MLton mailing list